Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Ensure we set ports / addresses while waiting for pod IPs #4095

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix: Ensure we set ports / addresses while waiting for pod IPs #4095

wants to merge 5 commits into from

Conversation

lacroixthomas
Copy link
Collaborator

@lacroixthomas lacroixthomas commented Jan 21, 2025 •
edited
Loading

What type of PR is this?
/kind bug

What this PR does / Why we need it:
Currently, the gameserver wait that the Pod IPs are populated before setting the ports and addresses

This seems to be blocking for a moment, we already have the ports and addresses from the node available, we should set them and keep waiting for the pod IPs until ready to move to GameServerStateScheduled (following this diagram: https://agones.dev/site/docs/reference/gameserver/#gameserver-state-diagram)

Which issue(s) this PR fixes:
Closes #3960

Special notes for your reviewer:
PR in draft: still need to do some manual testing

@github-actions github-actions bot added kind/bug These are bugs. size/S labels Jan 21, 2025
@lacroixthomas lacroixthomas changed the title fix: ensure we set ports addresses while waiting for pod IPs fix: Ensure we set ports / addresses while waiting for pod IPs Jan 21, 2025
@lacroixthomas
Copy link
Collaborator Author

Hello @0xaravindh
I've seen that you commented /gcbrun on my other PR which triggered the pipeline
Could you do it again for this one ? For me to do some manual testing with the new build 😄

@0xaravindh
Copy link
Member

/gcbrun

@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: 1ce69844-72da-4b87-b2ca-e583f2e40f32

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@0xaravindh
Copy link
Member

/gcbrun

@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: 396cc119-9ba3-48a5-b9d2-fe41781fda60

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@lacroixthomas
Copy link
Collaborator Author

@0xaravindh
I'm sorry to bother you again, can you re-comment for the pipeline ?

Or if there is a way to run it locally maybe ? Seems that it's the submit-e2e-test-cloud-build that is failing
Maybe it changed, but I previously be able to just push to run the pipeline, is it because it's in draft ?

@vicentefb
Copy link
Collaborator

/gcbrun

@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: c41e2f02-f528-4dee-ae6e-3e65d87da1fe

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@vicentefb
Copy link
Collaborator

Also, this is the guide to build it and test it locally https://github.com/googleforgames/agones/blob/main/build/README.md#testing-and-building

@vicentefb
Copy link
Collaborator

vicentefb commented Jan 22, 2025 •
edited
Loading

It currently fails on lint errors. Those can be caught by running make lint

agones/build/Makefile

Line 497 in bebe915

lint: LINT_TIMEOUT ?= 15m

@lacroixthomas
Copy link
Collaborator Author

Also, this is the guide to build it and test it locally https://github.com/googleforgames/agones/blob/main/build/README.md#testing-and-building

Thanks ! I'm gonna have a look to run that locally

@lacroixthomas
Copy link
Collaborator Author

Alright, I ran both the e2e that were failing TestSuperTuxKartGameServerReady and TestCreateConnect, they are now passing locally, and also fixed the linter issue and checked with make lint, it should be all good now 😄

@vicentefb
Copy link
Collaborator

/gcbrun

@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: af9e5b00-fe91-42ac-b238-9f0b49b64aab

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@vicentefb
Copy link
Collaborator

/gcbrun

@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: bd45a8dc-7e0a-484b-a8ab-6d1f6f1b74e1

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4095/head:pr_4095 && git checkout pr_4095
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.47.0-dev-ace3147

@lacroixthomas lacroixthomas marked this pull request as ready for review January 23, 2025 23:19
@lacroixthomas lacroixthomas force-pushed the bugfixes/delays-awaiting-pod-ips branch from ace3147 to 329bf81 Compare January 25, 2025 17:14
@0xaravindh
Copy link
Member

/gcbrun

@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 85654e2a-42c4-4649-8bcc-4032850ceaeb

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4095/head:pr_4095 && git checkout pr_4095
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.47.0-dev-329bf81

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miai10 miai10 miai10 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
kind/bug These are bugs. size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Game servers are having some delays until getting external IPs from agones SDK
5 participants
@lacroixthomas @0xaravindh @agones-bot @vicentefb @miai10