Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test abort in created state and cloud output mode #261

Closed
yorugac opened this issue Aug 3, 2023 · 1 comment
Closed

Add test abort in created state and cloud output mode #261

yorugac opened this issue Aug 3, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request PLZ

Comments

@yorugac
Copy link
Collaborator

yorugac commented Aug 3, 2023

Consider how to add monitoring of aborts from k6 Cloud in these cases:

  • before test run started.
  • in cloud output mode (check the logic with a single k6 first)
@yorugac yorugac added enhancement New feature or request PLZ labels Aug 3, 2023
@yorugac yorugac changed the title Add test abort in created state Add test abort in created state and cloud output Aug 8, 2023
@yorugac yorugac changed the title Add test abort in created state and cloud output Add test abort in created state and cloud output mode Aug 8, 2023
@yorugac yorugac self-assigned this Nov 6, 2023
@yorugac yorugac changed the title Add test abort in created state and cloud output mode Add test abort in created state and cloud output mode Nov 6, 2023
@yorugac
Copy link
Collaborator Author

yorugac commented Dec 7, 2023

"Global" aborts were implemented as part of PR #283: each k6 Cloud test run checks the abort status at the beginning of reconcile loop. If there's an abort status, the stop Job is created and test run is stopped. This logic works for both PLZ test run and cloud output test run.

Necessary caveat: if the test run hasn't been identified as k6 Cloud test run yet, it cannot be aborted at all. This scenario can happen with cloud output test run with an error from an initializer (e.g. badly formed script or arguments). It might make sense to look into this case more during #260.

@yorugac yorugac closed this as completed Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request PLZ
Projects
None yet
Development

No branches or pull requests

1 participant