Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i64 is used for integers when i32 should be used #53

Open
mathstuf opened this issue Jun 25, 2021 · 2 comments
Open

i64 is used for integers when i32 should be used #53

mathstuf opened this issue Jun 25, 2021 · 2 comments

Comments

@mathstuf
Copy link
Contributor

This code says that the spec doesn't have a size for numbers, but it does:

The Int scalar type represents a signed 32-bit numeric non-fractional value. Response formats that support a 32-bit integer or a number type should use that type to represent this scalar.

See: graphql-rust/graphql-client#266
@mathstuf mathstuf mentioned this issue Jun 25, 2021
Open
@tailhook
Copy link
Collaborator

tailhook commented Oct 8, 2021

This is true for inputs and outputs. But I'm still not sure it is true for literals.

@ittorchbearer
Copy link

I made a feature for this so it's not breaking and thus doesn't need to wait for a major version. Someone could even add deprecation notice or on move to v1.0.0 just switch it to default to i32 and still offer the i64 as a feature to make the transition easier for people. #65

jhult added a commit to jhult/mina-block-explorer that referenced this issue Jun 13, 2024
@jhult
fix: use u64 (instead of i64) for height, block height, nonce, and slot
0f76453 
graphql-rust/graphql-client#266
graphql-rust/graphql-parser#53
jhult added a commit to jhult/mina-block-explorer that referenced this issue Jun 19, 2024
@jhult
fix: use u64 (instead of i64)
e3c7b9d 
Fields include: limit, blocks_limit, snarks_limit, trans_limit, epoch, current_epoch, slot_in_epoch, selected_epoch, height, block_height, nonce, and slot

Fixes Granola-Team#600

Related:
- graphql-rust/graphql-client#266
- graphql-rust/graphql-parser#53
jhult added a commit to jhult/mina-block-explorer that referenced this issue Jun 26, 2024
@jhult
fix: use u64 (instead of i64)
825c50a 
Fields include: limit, blocks_limit, snarks_limit, trans_limit, epoch, current_epoch, slot_in_epoch, selected_epoch, height, block_height, nonce, and slot

Fixes Granola-Team#600

Related:
- graphql-rust/graphql-client#266
- graphql-rust/graphql-parser#53

a
jhult added a commit to jhult/mina-block-explorer that referenced this issue Jun 28, 2024
@jhult
fix: use u64 (instead of i64)
47243eb 
Fields include: limit, blocks_limit, snarks_limit, trans_limit, epoch, current_epoch, slot_in_epoch, selected_epoch, height, block_height, nonce, and slot

Fixes Granola-Team#600

Related:
- graphql-rust/graphql-client#266
- graphql-rust/graphql-parser#53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mathstuf @tailhook @ittorchbearer