Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

canary builds are broken #4161

Closed
yaacovCR opened this issue Aug 13, 2024 · 2 comments
Closed

canary builds are broken #4161

yaacovCR opened this issue Aug 13, 2024 · 2 comments

Comments

@yaacovCR
Copy link
Contributor

#4153 (comment)
@JoviDeCroock
Copy link
Member

Looks like it was a fluke, rerun made it work https://github.com/graphql/graphql-js/actions/runs/10371154738/job/28723496519

@yaacovCR
Copy link
Contributor Author

That's good news.

I upgraded our action scripts thinking that perhaps the deprecations were causing an issue, but it turns out not. Turns out also that it doesn't matter if we upgrade on the main branch as that isn't the default branch anymore. We could backport that PR to v16, but I guess it's fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yaacovCR @JoviDeCroock