Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When installing chromatism v3, console log is present in chromatism.umd.js #38

Open
jsonnull opened this issue Dec 7, 2017 · 3 comments

Comments

@jsonnull
Copy link

jsonnull commented Dec 7, 2017

If you want to see for yourself:

Browse to https://unpkg.com/[email protected]/dist/chromatism.umd.js

Perform a search for console.log

There's no console logs present in src on master... is it possible that the umd build was not built for the 3.0.0 release? What else could be causing this?

@TehShrike
Copy link
Contributor

I'd guess some uncommitted debug code was probably published.

That's one of the reasons I only ever release with these bash commands:

alias patch='pre-version && npm version patch && post-version'
alias feature='pre-version && npm version minor && post-version'
alias breaking='pre-version && npm version major && post-version'
alias pre-version='git diff --exit-code && npm prune && npm install -q && npm test'
alias post-version='(npm run build; exit 0) && git diff --exit-code && git push && git push --tags && npm publish'

it's saved me from bad publishes several times.

@jsonnull
Copy link
Author

jsonnull commented Dec 7, 2017

@TehShrike Yep, I'm personally a fan of https://github.com/sindresorhus/np

@TehShrike
Copy link
Contributor

For what it's worth, chromatism2 has no console.logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants