Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Including style in the code is unnecessary #179

Open
commongeek opened this issue Mar 22, 2024 · 1 comment
Open

Including style in the code is unnecessary #179

commongeek opened this issue Mar 22, 2024 · 1 comment

Comments

@commongeek
Copy link

commongeek commented Mar 22, 2024

A lot of styles are included in pygments, including solarized-dark (https://pygments.org/styles/).

Instead of putting the entire style code into coloring.py, you can just do something like this:

from pygments.styles import get_style_by_name

style = get_style_by_name('solarized-dark')
@gruns
Copy link
Owner

gruns commented Nov 12, 2024

@commongeek great suggestion! simpler is always better 👏

iirc coloring.py has a few differences with solarized-dark to look good in both light and dark terminals

that said, I'm all for simplifying things

might you be up to open a PR that removes coloring.py? or at least simplifies icecream to avoid a bunch of repeat code and colors in coloring.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants