Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Events to be Duplicated #231

Open
2 tasks done
nhatnghiho opened this issue Apr 14, 2023 · 5 comments
Open
2 tasks done

Allow Events to be Duplicated #231

nhatnghiho opened this issue Apr 14, 2023 · 5 comments
Labels
task Task issue for a current or past sprint

Comments

@nhatnghiho
Copy link
Contributor

nhatnghiho commented Apr 14, 2023

Description

We want to allow users to duplicate Custom Blocks.

Acceptance Criteria

UI Requirements

  • A new duplicate button is added to Event, which should display a popup saying "Duplicate event" when hovered over.

Functional Requirements

  • Event is duplicated correctly with a new ID.
@nhatnghiho nhatnghiho added the task Task issue for a current or past sprint label Apr 14, 2023
@nathangong
Copy link
Contributor

@nhatnghiho I don't think the Action interface (which is used for event icons) currently supports tooltips. Should I change the interface to include it? This would also mean adding a tooltip to all the other icons.

export type Action = {
  icon: FontAwesomeProps['icon'];
  styling?: React.CSSProperties;
  id?: string;
  onMouseEnter?: () => void;
  onMouseLeave?: () => void;
} & Omit<ButtonProps, 'children'>;

@nhatnghiho
Copy link
Contributor Author

@nhatnghiho I don't think the Action interface (which is used for event icons) currently supports tooltips. Should I change the interface to include it? This would also mean adding a tooltip to all the other icons.

export type Action = {
  icon: FontAwesomeProps['icon'];
  styling?: React.CSSProperties;
  id?: string;
  onMouseEnter?: () => void;
  onMouseLeave?: () => void;
} & Omit<ButtonProps, 'children'>;

Isn't it already been added? We have the tooltips for "Edit Color" and "Remove Event". Might need to merge from main

@nathangong
Copy link
Contributor

Ah I see, which branch should I PR to?

@nathangong
Copy link
Contributor

@nhatnghiho ^

@nhatnghiho
Copy link
Contributor Author

bog-changes-s23

samarth52 added a commit that referenced this issue Oct 20, 2023
### Summary

Resolves #231

Allows users to duplicate custom blocks

### Checklist

#### UI Requirements
- [x] A new duplicate button is added to `Event`, which should display a
popup saying "Duplicate event" when hovered over.

#### Functional Requirements
- [x] Event is duplicated correctly with a new ID.

### How to Test
Host website locally and test event duplication. Verify that duplicated
event id's are unique

Co-authored-by: Samarth Chandna <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task Task issue for a current or past sprint
Projects
None yet
Development

No branches or pull requests

2 participants