Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GT-Scheduler .ics export puts all classes 1 hour early #334

Open
code2BaseZia opened this issue Jan 6, 2025 · 2 comments · May be fixed by #336
Open

GT-Scheduler .ics export puts all classes 1 hour early #334

code2BaseZia opened this issue Jan 6, 2025 · 2 comments · May be fixed by #336
Labels
bug Feature is not working as intended.

Comments

@code2BaseZia
Copy link

Describe the bug
When my friend and I exported our respective schedules using the export "ICS Calendar file" button in the top right, we both uploaded our respective schedules to Google Calendar and the resulting schedule on Google Calendar was with every period an hour early. I used Chrome to both export and upload the file, they used Firefox for both operations. So if a class is at 12:30pm, it would be uploaded as 11:30am instead.

To Reproduce
Steps to reproduce the behavior. Example:

  1. Go to "Export"
  2. Click on "ICS (Calendar) File"
  3. Go to Google Calendar
  4. Click on "Settings"
  5. Click on "Import & Export"
  6. Upload the ICS file and click import

Expected behavior
The correct date and times for each class are uploaded as events to your Google Calendar

Screenshots
N/A

Additional context
I thought originally it could be a problem with timezones but at least on my Google Calendar's end my timezone and each event's timezone is right.
@code2BaseZia code2BaseZia added the bug Feature is not working as intended. label Jan 6, 2025
@rzhangbq
Copy link

rzhangbq commented Jan 9, 2025

Same issue here!

@cgensheimer cgensheimer linked a pull request Jan 10, 2025 that will close this issue
Open
@cgensheimer
Copy link

cgensheimer commented Jan 10, 2025 •
edited
Loading

Yeah I noticed this when I went to class at 4 PM and it was actually at 5 PM. You're right and it is caused by some bad code for timezone handling, it just comes from DST.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Feature is not working as intended.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Resolve GT-Scheduler .ics export puts all classes 1 hour early cgensheimer/website
3 participants
@rzhangbq @cgensheimer @code2BaseZia