Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression from earlier version, aria-colindex missing from table #2360

Closed
pascal-pfeiffer opened this issue Jul 2, 2024 · 2 comments
Closed
Labels
devx Related to developer experience

Comments

@pascal-pfeiffer
Copy link

Wave SDK Version, OS

Wave 1.3.4

Actual behavior

Somewhere between v1.0.2 and 1.3.4 the aria-colindex for tables was dropped. This information was especially helpful for automated UI testing, so it would be great to get it back.

v1.0.2
image

v1.3.4:
image

Expected behavior

aria-colindex being set for tables

@pascal-pfeiffer pascal-pfeiffer added the bug Bug in code label Jul 2, 2024
@marek-mihok
Copy link
Contributor

marek-mihok commented Jul 16, 2024

It was removed by FluentUI in version 8.52.1 according to its CHANGELOG:

{
      "date": "Tue, 01 Feb 2022 07:26:25 GMT",
      "tag": "@fluentui/react_v8.52.1",
      "version": "8.52.1",
      "comments": {
        "patch": [
          {
            "author": "[email protected]",
            "package": "@fluentui/react",
            "commit": "c4912723213bb1a15b4af2f6c7962bc32064bf4a",
            "comment": "remove aria-colindex from DetailsList columns by default, fix aria-label and aria-description on column headers"
          },
...

Looking to docs it does not seem to be necessary:
If all of the columns are present in the DOM, including aria-colindex is not necessary as user agents can calculate the column index of each cell or gridcell. However, if any of the columns are left out of the DOM at any time, use aria-colindex to indicate the column of each cell or gridcell with respect to the full table.

The Wave regression lies in #2201 where we updated Fluent version from 8.49.0 to 8.58.0

Looking to the Fluent commit, there is a new data-item-key property, but it only adresses column headers.

Is there any other way how you could adjust your tests? E.g. by querying the children of ms-DetailsRow-fields component?

UPDATE:
There is a new data-automation-key for cells:
image

@pascal-pfeiffer
Copy link
Author

Thank you @marek-mihok for all the digging and the great solution!
Indeed, we can use data-automation-key for these tests. Makes sense to deprecate an index in favor for an easy understandable key.

@mturoci mturoci added devx Related to developer experience and removed bug Bug in code labels Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devx Related to developer experience
Projects
None yet
Development

No branches or pull requests

3 participants