You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Somewhere between v1.0.2 and 1.3.4 the aria-colindex for tables was dropped. This information was especially helpful for automated UI testing, so it would be great to get it back.
v1.0.2
v1.3.4:
Expected behavior
aria-colindex being set for tables
The text was updated successfully, but these errors were encountered:
It was removed by FluentUI in version 8.52.1 according to its CHANGELOG:
{
"date": "Tue, 01 Feb 2022 07:26:25 GMT",
"tag": "@fluentui/react_v8.52.1",
"version": "8.52.1",
"comments": {
"patch": [
{
"author": "[email protected]",
"package": "@fluentui/react",
"commit": "c4912723213bb1a15b4af2f6c7962bc32064bf4a",
"comment": "remove aria-colindex from DetailsList columns by default, fix aria-label and aria-description on column headers"
},
...
Looking to docs it does not seem to be necessary: If all of the columns are present in the DOM, including aria-colindex is not necessary as user agents can calculate the column index of each cell or gridcell. However, if any of the columns are left out of the DOM at any time, use aria-colindex to indicate the column of each cell or gridcell with respect to the full table.
The Wave regression lies in #2201 where we updated Fluent version from 8.49.0 to 8.58.0
Looking to the Fluent commit, there is a new data-item-key property, but it only adresses column headers.
Is there any other way how you could adjust your tests? E.g. by querying the children of ms-DetailsRow-fields component?
UPDATE:
There is a new data-automation-key for cells:
Thank you @marek-mihok for all the digging and the great solution!
Indeed, we can use data-automation-key for these tests. Makes sense to deprecate an index in favor for an easy understandable key.
Wave SDK Version, OS
Wave 1.3.4
Actual behavior
Somewhere between v1.0.2 and 1.3.4 the aria-colindex for tables was dropped. This information was especially helpful for automated UI testing, so it would be great to get it back.
v1.0.2
![image](https://private-user-images.githubusercontent.com/1069138/344974038-df81b05e-f8fc-44e9-8341-adcfe4d2f30d.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1NzkxNTUsIm5iZiI6MTczOTU3ODg1NSwicGF0aCI6Ii8xMDY5MTM4LzM0NDk3NDAzOC1kZjgxYjA1ZS1mOGZjLTQ0ZTktODM0MS1hZGNmZTRkMmYzMGQucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxNSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTVUMDAyMDU1WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9OWViZGEzNDc1OTYyNzBmNTc4NDg1M2QzYTViNmIwNjZmNjcyZGJlYjdiNGYwMjNjY2U5MDdkZTY1ODY4NmJmYyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.bVhEQ07IZszGA564RnIYghIBrZ_ZVKIGHCR4nxKbGsk)
v1.3.4:
![image](https://private-user-images.githubusercontent.com/1069138/344974542-d59942d5-a5bb-4851-bbb5-a9061b76b31d.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1NzkxNTUsIm5iZiI6MTczOTU3ODg1NSwicGF0aCI6Ii8xMDY5MTM4LzM0NDk3NDU0Mi1kNTk5NDJkNS1hNWJiLTQ4NTEtYmJiNS1hOTA2MWI3NmIzMWQucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxNSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTVUMDAyMDU1WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YjMzYWFjNjg3NTAwNmNkMmExNmQ1ZWIxMzVjOWRiMWUwODNlMjRhNjIwNGI2MTk1MzViNmJiZWY5YWQ3YTM4MyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.yIdTnenT1lzOndDNLfOg-8Kh6khKT8N9e7vXnN1W5IY)
Expected behavior
aria-colindex being set for tables
The text was updated successfully, but these errors were encountered: