Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor styling element into separate classes in CSS files #44

Open
kaseyliu opened this issue Feb 27, 2025 · 0 comments · May be fixed by #52
Open

Refactor styling element into separate classes in CSS files #44

kaseyliu opened this issue Feb 27, 2025 · 0 comments · May be fixed by #52

Comments

@kaseyliu
Copy link
Collaborator

kaseyliu commented Feb 27, 2025

Description
Right now, most of our styling elements are coded as inline styling on the Chakra element's style={}. However, many of them are the same and we want to remove the repetition. We would prefer to separate the styling elements (for all files) into a const that can be exported in. We can do this in the same file as the component, for example:
export const cardStyles = { p: 4, … }; <Box {...cardStyles}> If you notice common styling across multiple files/components, then make a separate file for the styling that the other files can import. Let us know if you have any questions!

@soramicha soramicha self-assigned this Feb 28, 2025
@soramicha soramicha linked a pull request Mar 7, 2025 that will close this issue
6 tasks
@soramicha soramicha linked a pull request Mar 7, 2025 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants