Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: updated Jest config to collect coverage from src/ #56

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

chore: updated Jest config to collect coverage from src/ #56

wants to merge 3 commits into from

Conversation

HenryHorse
Copy link
Collaborator

Developer: Shayan

Closes #50

Pull Request Summary

Modified jest to run coverage on all source files in src/

Modifications

Changed collectCoverageFrom and coverageThreshold in jest.config.ts

Testing Considerations

I ran npm test and got a coverage report back

Pull Request Checklist

  • Code is neat, readable, and works
  • Comments are appropriate
  • The commit messages follows our guidelines
  • The developer name is specified
  • The summary is completed
  • Assign reviewers

Screenshots/Screencast

Screenshot 2025-02-10 at 6 44 15 PM

@vercel Vercel
Copy link

vercel bot commented Feb 11, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
surfrider ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 6, 2025 4:25am

ryanhu021
ryanhu021 requested changes Feb 11, 2025
View reviewed changes
Copy link
Collaborator

@ryanhu021 ryanhu021 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to include this in the issue -- could you exclude src/components/ui from coverage since we won't be testing shadcn components? Thanks!

@HenryHorse
Copy link
Collaborator Author

Should be excluded now!

ryanhu021
ryanhu021 approved these changes Feb 11, 2025
View reviewed changes
Copy link
Collaborator

@ryanhu021 ryanhu021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! We won't be able to merge yet because the new threshold is causing the ci to fail, but there's nothing you have to do on your end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanhu021 ryanhu021 ryanhu021 approved these changes

@ryanchansf ryanchansf Awaiting requested review from ryanchansf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add coverage requirement for jest
2 participants
@HenryHorse @ryanhu021