feat: implemented calculator form input validation #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ryanhu021
requested changes
Feb 27, 2025
|
|
||
| const powerPlantOptions = PowerPlantClass.options; | ||
| const locationOptions = Location.options; | ||
|
|
||
| const currentYear = new Date().getFullYear(); | ||
|
|
||
| export const CalculateInputSchema = z.object({ |
There was a problem hiding this comment.
This object looks very similar to the CalculateInput object in the schema. Could we add these validation rules to the schema instead? Then we can just reuse the CalculateInput object instead of creating a new one. Also it would be helpful to add some unit tests for these rules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Developer: Talia Vivrett
Closes #78
Pull Request Summary
Completed form validation for user inputs to calculator
Modifications
Added to CalculatorForm.tsx
Testing Considerations
Test for error messages when entering incorrect inputs
Pull Request Checklist
Screenshots/Screencast
{put screenshots of your change, or even better a screencast displaying the functionality}