Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove /#/ in site URL #196

Open
TeddyCr opened this issue Dec 12, 2019 · 2 comments
Open

Remove /#/ in site URL #196

TeddyCr opened this issue Dec 12, 2019 · 2 comments

Comments

@TeddyCr
Copy link
Contributor

TeddyCr commented Dec 12, 2019

@hackla-engage/frontend-engineers is it possible to remove the /#/ in the URL of the site? If not would you be able to explain why it is included?

Thank you. :)

@ldaws003
Copy link
Contributor

@TeddyCr Not sure you can remove it. It is from the createHashHistory function in the configureStore.dev.js file. I replaced it with createBrowserHistory but when I tried to go to the agenda feed, I got an error unless I went to the homepage and clicked the link to go there.

@ldaws003
Copy link
Contributor

@TeddyCr We could make it so that whenever someone tries to go to any other page than the home page, they would be redirected to the app and then send a json response containing the pathname and have the app redirect to that.

Such as when someone types and then go to engage.town/feed the backend would redirected them to engage.town and send a json telling the fronted to render the feed using the history api.

This would allow browser history to act normally. Any thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants