Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google_container_cluster: Add support for initialClusterVersion #20998

Open
safaci2000 opened this issue Jan 22, 2025 · 1 comment
Open

google_container_cluster: Add support for initialClusterVersion #20998

safaci2000 opened this issue Jan 22, 2025 · 1 comment

Comments

@safaci2000
Copy link

safaci2000 commented Jan 22, 2025

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
  • Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.
  • If an issue is assigned to a user, that user is claiming responsibility for the issue.
  • Customers working with a Google Technical Account Manager or Customer Engineer can ask them to reach out internally to expedite investigation and resolution of this issue.

Description

When creating a GKE cluster the version of the master node is set via the initialClusterVersion as can be seen detailed in the API spec here: https://cloud.google.com/kubernetes-engine/docs/reference/rest/v1beta1/projects.locations.clusters

string

The initial Kubernetes version for this cluster. Valid versions are those found in validMasterVersions returned by getServerConfig. The version can be upgraded over time; such upgrades are reflected in currentMasterVersion and currentNodeVersion.

Users may specify either explicit versions offered by Kubernetes Engine or version aliases, which have the following behavior:

"latest": picks the highest valid Kubernetes version
"1.X": picks the highest valid patch+gke.N patch in the 1.X version
"1.X.Y": picks the highest valid gke.N patch in the 1.X.Y version
"1.X.Y-gke.N": picks an explicit Kubernetes version
"","-": picks the default Kubernetes version

I saw an older ticket that asks for a similar request listed here but I'm not sure if the feature did not exist then or I'm not understanding something. If this feature already exists please let me know.

New or Affected Resource(s)

  • google_container_cluster

Potential Terraform Configuration

NA

References

https://cloud.google.com/kubernetes-engine/docs/reference/rest/v1beta1/projects.locations.clusters

b/392629415

@github-actions github-actions bot added forward/review In review; remove label to forward service/container labels Jan 22, 2025
@safaci2000 safaci2000 changed the title Add support for initialClusterVersion google_container_cluster: Add support for initialClusterVersion Jan 22, 2025
@rileykarson
Copy link
Collaborator

This is supported as https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/container_cluster#min_master_version-1, which maps to cluster version update mechanics as well

We could probably add support for a separate initial field that was never used for updates, but it would be very prone to recreating the resource because changes would imply a recreation so that that was the initial version of the cluster.

@rileykarson rileykarson added size/s and removed forward/review In review; remove label to forward labels Jan 27, 2025
@rileykarson rileykarson added this to the Backlog milestone Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants