Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn about use of sign_in user, bypass: true also warns: Passing the result of caller to ActiveSupport::Deprecation#warn is deprecated #5739

Open
JasonBarnabe opened this issue Dec 11, 2024 · 0 comments

Comments

@JasonBarnabe
Copy link

Environment

  • Ruby 3.3.6
  • Rails 7.2.2.1
  • Devise 4.9.4

Current behavior

sign_in user, bypass: true

results in the warning

DEPRECATION WARNING: Passing the result of `caller` to ActiveSupport::Deprecation#warn is deprecated and will be removed in Rails 8.0.
Please pass the result of `caller_locations` instead.

Devise.deprecator.warn(<<-DEPRECATION.strip_heredoc, caller)

And presumably will fail in Rails 8 too.

Expected behavior

Not fail, not warn about the ActiveSupport thing, but still warn

[Devise] bypass option is deprecated and it will be removed in future version of Devise.
Please use bypass_sign_in method instead.
Example:

  bypass_sign_in(user)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant