From 8e361decf3212eb185b1883f837811870d8dc0c9 Mon Sep 17 00:00:00 2001 From: Arnthorny Date: Wed, 7 Aug 2024 17:57:45 +0100 Subject: [PATCH] chore: Changed endpoint status code from 200 OK to 204 NO Content --- api/v1/routes/invitations.py | 11 +++-------- tests/v1/invitation/test_delete_invitation.py | 6 +----- 2 files changed, 4 insertions(+), 13 deletions(-) diff --git a/api/v1/routes/invitations.py b/api/v1/routes/invitations.py index 21018a327..686b7d236 100644 --- a/api/v1/routes/invitations.py +++ b/api/v1/routes/invitations.py @@ -1,4 +1,4 @@ -from fastapi import APIRouter, Depends, HTTPException, Request +from fastapi import APIRouter, Depends, HTTPException, Request, status from sqlalchemy.orm import Session from urllib.parse import urlparse, parse_qs from api.v1.schemas import invitations @@ -45,7 +45,7 @@ async def add_user_to_organization( return invite.InviteService.add_user_to_organization(invite_id, session) -@invites.delete("/{invite_id}", status_code=200, response_model=success_response) +@invites.delete("/{invite_id}", status_code=status.HTTP_204_NO_CONTENT) def delete_invite( invite_id: str, db: Session = Depends(get_session), @@ -57,9 +57,4 @@ def delete_invite( if not invite_is_deleted: raise HTTPException(status_code=404, detail="Invalid invitation id") - logging.info(f"Deleted invite. ID: {invite_id}") - - return success_response( - status_code=200, - message='Invite deleted successfully', - ) \ No newline at end of file + logging.info(f"Deleted invite. ID: {invite_id}") \ No newline at end of file diff --git a/tests/v1/invitation/test_delete_invitation.py b/tests/v1/invitation/test_delete_invitation.py index 62ea8bf20..9f01222b0 100644 --- a/tests/v1/invitation/test_delete_invitation.py +++ b/tests/v1/invitation/test_delete_invitation.py @@ -41,11 +41,7 @@ def test_delete_invite_success(self, client): response = client.delete(DELETE_ENDPOINT) - assert response.status_code == 200 - assert response.json()['message'] == "Invite deleted successfully" - assert response.json().get('data') == None - assert response.json()['success'] == True - + assert response.status_code == 204 # Invalid invite id def test_delete_invite_invalid_id(self, client):