Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-printing characters mess up tab completion #15

Closed
aleclarson opened this issue Feb 14, 2018 · 6 comments
Closed

Non-printing characters mess up tab completion #15

aleclarson opened this issue Feb 14, 2018 · 6 comments

Comments

@aleclarson
Copy link
Contributor

I want to use ANSI coloring on my prompt string, but tab completion is broken by it.

Can this be fixed in this library, or should I create an issue in the C repo?

@hoelzro
Copy link
Owner

hoelzro commented Feb 15, 2018

Thanks for the report! This will need to need to be handled up the upstream - once it is I can grab the code and integrated it into this library.

@Sonophoto
Copy link

Guys let me point out this discussion to save some time. antirez/linenoise#25

@aleclarson
Copy link
Contributor Author

@Sonophoto Thanks, Brig! 👍

@hoelzro The best option right now is to use https://github.com/yhirose/linenoise/tree/utf8-support instead. I'll gladly send a pull request over if you agree.

@hoelzro
Copy link
Owner

hoelzro commented Feb 21, 2018

@Sonophoto Thanks for the link, but I don't think this is related to multi-byte support. This is about using ANSI colors for the prompt and linenoise improperly calculating the prompt length.

@aleclarson
Copy link
Contributor Author

@hoelzro Don't speak too soon! ;) #18 fixes this issue. :D

@hoelzro
Copy link
Owner

hoelzro commented Feb 26, 2018

@aleclarson Do you mind if I close this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants