Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Some errors are logged without timestamp and plugin name #520

Open
mantorok1 opened this issue Feb 11, 2024 · 2 comments
Open

Bug: Some errors are logged without timestamp and plugin name #520

mantorok1 opened this issue Feb 11, 2024 · 2 comments
Assignees
Labels
bug Something isn't working pinned

Comments

@mantorok1
Copy link
Collaborator

Describe The Bug

Some errors are logged without timestamp and plugin name

To Reproduce

Turn off RainBird controller for a while so plugin cannot connect to it

Expected behavior

Error log messages should be prefixed with timestamp and plugin name

Relevant log output

Since version 2.0 of plugin error are logged like this:
RainBird controller request failed. [Error: connect EHOSTUNREACH 192.168.1.105:80]
Failed Request: [18] [ControllerDateGetRequest]
Will retry in 60 seconds
RainBird controller request failed. [Error: connect EHOSTUNREACH 192.168.1.105:80]
Failed Request: [18] [ControllerDateGetRequest]
Will retry in 60 seconds
RainBird controller request failed. [Error: connect EHOSTUNREACH 192.168.1.105:80]
Failed Request: [18] [ControllerDateGetRequest]
Will retry in 60 seconds
RainBird controller request failed. [Error: connect EHOSTUNREACH 192.168.1.105:80]
Failed Request: [18] [ControllerDateGetRequest]
Will retry in 60 seconds
RainBird controller request failed. [Error: connect EHOSTUNREACH 192.168.1.105:80]
Failed Request: [18] [ControllerDateGetRequest]
Will retry in 60 seconds

Note that timestamp and plugin name are missing

Config for homebridge-rainbird

N/A

Screenshots

No response

Device & Model

TM2

Node.js Version

v18.18.2

NPM Version

v9.8.1

Homebridge Version

v1.7.0

Homebridge Rainbird Plugin Version

v2.0.0

Homebridge Config UI X Plugin Version

v4.55.1

Operating System

Docker

@mantorok1 mantorok1 added the bug Something isn't working label Feb 11, 2024
@donavanbecker
Copy link
Contributor

@mantorok1 just released 2.0.3, which you implemented the event loggings, right? So we should be able to close this?

@mantorok1
Copy link
Collaborator Author

I believe so. Does it work ok? I haven't had a chance to test it yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pinned
Projects
None yet
Development

No branches or pull requests

2 participants