Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to use external data format in pipeline initialization #1180

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sroussey
Copy link
Contributor

@sroussey sroussey commented Feb 1, 2025

This is for large models. See issue #1179

@benc-uk
Copy link

benc-uk commented Feb 16, 2025

Wait what? So the option use_external_data_format wasn't being used at all, when creating a pipeline !?
🤯🤯🤯

@sroussey
Copy link
Contributor Author

Wait what? So the option use_external_data_format wasn't being used at all, when creating a pipeline !? 🤯🤯🤯

I don't have the code in front of me, but I think you can use session_options as a workaround:

pipeline("...", { session_options: use_external_data_format

@benc-uk
Copy link

benc-uk commented Feb 18, 2025

session_options

Setting it under session_options didn't make a difference.
Even if it did the levels of undocumented configuration this project has is unfathomable

@sroussey
Copy link
Contributor Author

I could publish my version with the fix if you are in a bind. Was thinking of starting to do that again to get some things I want where I have made changes.

As for as docs... the API stuff looks like it comes from source. Which is likely why the docs callback params are non-existent.

I'm trying to learn the code a bit by translating into TypeScript (transformers.ts!). But I'm trying not to change the code while I do it (or even the JSDocs) as I don't want to change too many lines of code. I really should keep some notes as I go though.

I think I can make the bundle a bit smaller and get better types.

I just do when I'm frustrated at something else I'm working on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants