Fix: Use config.use_sliding_window instead of config.sliding_window #36366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
KarthikaRajagopal44
force-pushed
the
qwen2-sliding-window-fix
branch
from
e6634f1 to
786a0f4
Compare
KarthikaRajagopal44
force-pushed
the
qwen2-sliding-window-fix
branch
from
786a0f4 to
d521d03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where
config.sliding_window(a number) is incorrectly treated as a boolean.The condition now checks
config.use_sliding_windowto avoid unintended warning messages.Fixes #36361