You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor siglip2 fast image processor to be more consistent with others and reduce diffs.
Also introduce unused_kwargs in BaseImageProcessorFast for processors that don't support all the default kwargs. Here SigLip doesn't support the size kwarg for example, which might be surprising for users considering it is supported by (almost) all other image processors. adding it in unused_kwargs allows to show a warning instead of raising an error.
Cc @qubvel
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.
Can you please also check if we can make docs consistent for slow and fast image processors?
Yes indeed, that's a problem with all fast processors really. I'm trying to strike a good balance between having meaningful and correct docs, and not having the same image processing kwargs docs duplicated in every processors.
Maybe we can have a decorator that allows to override the default description of a kwarg if we need to?
In any case, I'll try to come up with something better than the current situation, but I'll probably open another PR for that
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Refactor siglip2 fast image processor to be more consistent with others and reduce diffs.
Also introduce
unused_kwargsinBaseImageProcessorFastfor processors that don't support all the default kwargs. Here SigLip doesn't support thesizekwarg for example, which might be surprising for users considering it is supported by (almost) all other image processors. adding it inunused_kwargsallows to show a warning instead of raising an error.Cc @qubvel