Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[save_pretrained ] Skip collecting duplicated weight #36409

Merged
merged 2 commits into from
Feb 27, 2025
Merged

[save_pretrained ] Skip collecting duplicated weight #36409

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4cb7afc
Skip collecting duplicated weight
wejoncy Feb 26, 2025
3d5108e
format
wejoncy Feb 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/transformers/modeling_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3056,6 +3056,9 @@ def save_pretrained(
# init state_dict for this shard
shard_state_dict = {name: "" for name in shard}
for module_name in shard:
# skip to collect this weight again
if shard_state_dict.get(module_name) != "":
continue
module = module_map[module_name]
# update state dict with onloaded parameters
shard_state_dict = get_state_dict_from_offload(module, module_name, shard_state_dict)
Expand Down