Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change PR to draft when it is (re)opened #36417

Merged
merged 28 commits into from
Feb 27, 2025
Merged

Change PR to draft when it is (re)opened #36417

merged 28 commits into from
Feb 27, 2025

Conversation

ydshieh
Copy link
Collaborator

@ydshieh ydshieh commented Feb 26, 2025

What does this PR do?

This PR is a first step: it simply change a PR to draft when it is (re)opened. It doesn't modify yet the logic regarding how CI should be triggered.

See this example.

It also sends a comment, see

Screenshot 2025-02-26 151945

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@ydshieh ydshieh changed the title [Draft] Change to draft Change PR to draft when it is (re)opened Feb 26, 2025
name: Change PR to draft

on:
pull_request_target:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use pull_request_target instead of pull_request for security.

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice but can we check if it's not already draft mode ?

@ydshieh
Copy link
Collaborator Author

ydshieh commented Feb 26, 2025

Yes we can check of course. I will update. Also disable tests but keep checks on circleCI

@ydshieh ydshieh marked this pull request as draft February 26, 2025 17:00
@ydshieh ydshieh marked this pull request as ready for review February 26, 2025 18:00
@ydshieh ydshieh merged commit d0727d9 into main Feb 27, 2025
11 checks passed
@ydshieh ydshieh deleted the change_to_draft branch February 27, 2025 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants