Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SBML Simulation Feature Improvements 2 #756

Open
4 of 5 tasks
hasanbalci opened this issue Feb 3, 2025 · 4 comments
Open
4 of 5 tasks

SBML Simulation Feature Improvements 2 #756

hasanbalci opened this issue Feb 3, 2025 · 4 comments
Assignees

Comments

@hasanbalci
Copy link
Contributor

hasanbalci commented Feb 3, 2025

  • If we add a local parameter to one of the process simulation properties before simulation it throws "rxn.createLocalParameter is not a function" error.
  • It might be good to add axis labels in the generated plot.
  • We generally left-align modal titles and place a right-aligned X button to close them in the header field. It would be good to apply same to the Simulation dialog. Also title may be changed to "Simulation Result".
  • We should add a "Default" button to "Map properties -> Simulation" section like in the other sections to be able return to default values.
  • In some cases, legend can be large and may overlap with the simulation result. If the library we are using allows it, can we make it optional for the user to choose where to place the legend? Or maybe we can place it directly to the right or below the chart, if possible.
    Image
@umut-er
Copy link
Contributor

umut-er commented Feb 7, 2025

I am tentatively checking all of the boxes as I have pushed changes for all of the items. Please take a look when you have the time.

@hasanbalci
Copy link
Contributor Author

@umut-er Thanks, the issues I mentioned before have been resolved. I came across a new case, it would be good if we could fix that too.

@umut-er
Copy link
Contributor

umut-er commented Feb 9, 2025

@hasanbalci I have tried to fix the legend before, but this was the best I was able to do. Putting it outside the graph compresses the graph way too much. However, I think we can implement an additional functionality to give the user the raw data, say, in .csv form, and they can plot it in whatever software they like.

@ugurdogrusoz
Copy link
Contributor

@umut-er How about a button that pops up the legend temporarily until the next click?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants