Button text_color should be an Option<Color>

[DJ-Laser]

Is your issue REALLY a bug?

• My issue is indeed a bug!
• I am not crazy! I will not fill out this form just to ask a question or request a feature. Pinky promise.

Is there an existing issue for this?

• I have searched the existing issues.

Is this issue related to iced?

• My hardware is compatible and my graphics drivers are up-to-date.

What happened?

I am making an app launcher for my custom linux DE, and so to make everything look consistent I made a custom Theme struct based on the base16 style scheme. My problem was that all text inside of a button was black, even when i set the app theme to use white text. All other text was fine.

After some painful debugging I realized my mistake. I was implementing Catalog for container like this:

// use container::{...}
impl Catalog for Base16Theme {
  type Class<'a> = StyleFn<'a, Self>;

  fn default<'a>() -> Self::Class<'a> {
    Box::new(|_theme| Style::default())
  }

  fn style(&self, class: &Self::Class<'_>) -> Style {
    class(self)
  }
}

This had the expected behavior because by default the text_color is none, making the text inherit it's color.
I slightly modified this to get my button Catalog impl.

// use button::{...}
impl Catalog for Base16Theme {
  type Class<'a> = StyleFn<'a, Self>;

  fn default<'a>() -> Self::Class<'a> {
    Box::new(|_theme, _status| Style::default())
  }

  fn style(&self, class: &Self::Class<'_>, status: Status) -> Style {
    class(self, status)
  }
}

The problem was that for button, text_color::default is black, not none, overriding the default styles for the widgets placed inside.
I believe that button should behave the same as text and container, and allow inheriting the base text color style from it's parent

What is the expected behavior?

I expected button to behave the same as container, and inherit the text styling from the parent

Version

crates.io release

Operating System

Linux

Do you have any log output?

No response