Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming: using Teams Card instead of Teams Alarm when applicable #232

Open
1 task done
blalop opened this issue Nov 3, 2020 · 1 comment
Open
1 task done

Renaming: using Teams Card instead of Teams Alarm when applicable #232

blalop opened this issue Nov 3, 2020 · 1 comment

Comments

@blalop
Copy link
Member

blalop commented Nov 3, 2020

Prerequisites

Description

The codebase still uses the terms "Team Alarm" after the TemplateComposer already has generated the message that is to be sent to Teams. Those messages are no longer Alarms, as a Teams card can be composed by one or more Alarms.

For better readability of the code, Team Alarms references after a TemplateComposer.compose_all method call should be renamed to Teams Cards.

Steps to Reproduce

N/A

Versions

N/A

@stale
Copy link

stale bot commented Jan 2, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jan 2, 2021
@vicsufer vicsufer added the pinned label Jan 7, 2021
@stale stale bot removed the wontfix label Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants