Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

anti corruption layer - Issue 1325. #2777

Merged
merged 16 commits into from
Mar 17, 2024
Merged

anti corruption layer - Issue 1325. #2777

merged 16 commits into from
Mar 17, 2024

Conversation

besok
Copy link
Contributor

@besok besok commented Nov 27, 2023 •
edited
Loading

closes #1325

Describes the anti-corruption pattern

  • added a new pattern

@besok besok marked this pull request as draft November 27, 2023 06:35
@besok besok marked this pull request as ready for review November 29, 2023 05:27
@besok
Copy link
Contributor Author

besok commented Nov 29, 2023

do i need to fix sonar issues?
The tests here just to demonstrate how the pattern works.

@besok
Copy link
Contributor Author

besok commented Dec 3, 2023

Hello @iluwatar!
Could you please give a look at this PR?

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

0.0% Coverage on New Code (required ≥ 80%)
4.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@stale Stale
Copy link

stale bot commented Jan 27, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the status: stale issues and pull requests that have not had recent interaction label Jan 27, 2024
@stale stale bot removed the status: stale issues and pull requests that have not had recent interaction label Jan 30, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

0.0% Coverage on New Code (required ≥ 80%)
4.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@besok besok changed the title anti corruption layer - Issue 1325 anti corruption layer - Issue 1325. Feb 21, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@iluwatar iluwatar merged commit 5c47447 into iluwatar:master Mar 17, 2024
1 check passed
@iluwatar
Copy link
Owner

Looks good! Thank you for the contribution 🎉

@all-contributors please add @besok for code

@allcontributors AllContributors
Copy link
Contributor

@iluwatar

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

@besok already contributed before to code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iluwatar iluwatar iluwatar approved these changes

Assignees
No one assigned
Labels
status: under review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Anti-Corruption Layer pattern
2 participants
@besok @iluwatar