Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reference to hamcrest and added ETL pattern #3183

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

varada610
Copy link

Pull Request Template

What does this PR do?

Removes usage of hamcrest across the repo and Junit 4 references removed.

Copy link

github-actions bot commented Jan 28, 2025

PR Summary

This PR removes the usage of Hamcrest and JUnit 4 across the repository. It also includes the addition of a new ETL module and updates to several test files. The changes involve updating dependencies, removing Hamcrest assertions, and using JUnit 5 assertions instead. Several files also received updated license headers.

Changes

File Summary
bloc/pom.xml Removed Hamcrest dependency and updated to JUnit 5. The license header was also updated.
bloc/src/main/java/com/iluwatar/bloc/Bloc.java Updated license header. No functional changes were made to the code.
bloc/src/main/java/com/iluwatar/bloc/BlocUi.java Updated license header. No functional changes were made to the code.
bloc/src/main/java/com/iluwatar/bloc/ListenerManager.java Updated license header. No functional changes were made to the code.
bloc/src/main/java/com/iluwatar/bloc/Main.java Updated license header. No functional changes were made to the code.
bloc/src/main/java/com/iluwatar/bloc/State.java Updated license header. No functional changes were made to the code.
bloc/src/main/java/com/iluwatar/bloc/StateListener.java Updated license header. No functional changes were made to the code.
bloc/src/test/java/com/iluwatar/bloc/BlocTest.java Updated license header and migrated to JUnit 5. Assertions were updated to JUnit 5 style.
bloc/src/test/java/com/iluwatar/bloc/BlocUiTest.java Updated license header and migrated to JUnit 5. Assertions were updated to JUnit 5 style.
bloc/src/test/java/com/iluwatar/bloc/MainTest.java Updated license header and migrated to JUnit 5. Assertions were updated to JUnit 5 style.
etl/etc/etl.urm.puml New file. Contains a plantuml diagram.
etl/pom.xml New file. Contains maven dependencies for the ETL module.
etl/src/main/java/com/iluwatar/etl/App.java New file. Main class for the ETL module. It extracts and transforms data from a CSV file.
etl/src/main/java/com/iluwatar/etl/Extract.java New file. Extracts data from a CSV file.
etl/src/main/java/com/iluwatar/etl/Transform.java New file. Transforms extracted data into JSON format and writes it to a file.
etl/src/main/resources/SocialMediaTop100.csv New file. Contains sample data for the ETL module.
fluent-interface/README.md Removed reference to Hamcrest from the list of examples in the README.
health-check/src/test/java/HealthEndpointIntegrationTest.java Updated assertions to use JUnit 5 style assertions instead of Hamcrest.
marker-interface/pom.xml Removed Hamcrest dependency.
marker-interface/src/test/java/GuardTest.java Updated assertions to use JUnit 5 style assertions instead of Hamcrest.
marker-interface/src/test/java/ThiefTest.java Updated assertions to use JUnit 5 style assertions instead of Hamcrest.
microservices-idempotent-consumer/src/test/java/com/iluwatar/idempotentconsumer/AppTest.java Updated license header. No functional changes were made to the code.
microservices-idempotent-consumer/src/test/java/com/iluwatar/idempotentconsumer/RequestStateMachineTests.java Updated license header. No functional changes were made to the code.
retry/pom.xml Removed Hamcrest dependency.
retry/src/test/java/com/iluwatar/retry/FindCustomerTest.java Updated assertions to use JUnit 5 style assertions instead of Hamcrest.
retry/src/test/java/com/iluwatar/retry/RetryExponentialBackoffTest.java Updated assertions to use JUnit 5 style assertions instead of Hamcrest.
retry/src/test/java/com/iluwatar/retry/RetryTest.java Updated assertions to use JUnit 5 style assertions instead of Hamcrest.
virtual-proxy/src/test/java/com/iluwatar/virtual/proxy/RealVideoObjectTest.java Updated assertions to use JUnit 5 style assertions instead of Hamcrest.
virtual-proxy/src/test/java/com/iluwatar/virtual/proxy/VideoObjectProxyTest.java Updated assertions to use JUnit 5 style assertions instead of Hamcrest.

autogenerated by presubmit.ai

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Review Summary

Commits Considered (1)
  • 12f34d2: Remove reference to hamcrest for testing
Files Processed (23)
  • bloc/pom.xml (1 hunk)
  • bloc/src/main/java/com/iluwatar/bloc/Bloc.java (1 hunk)
  • bloc/src/main/java/com/iluwatar/bloc/BlocUi.java (1 hunk)
  • bloc/src/main/java/com/iluwatar/bloc/ListenerManager.java (1 hunk)
  • bloc/src/main/java/com/iluwatar/bloc/Main.java (1 hunk)
  • bloc/src/main/java/com/iluwatar/bloc/State.java (1 hunk)
  • bloc/src/main/java/com/iluwatar/bloc/StateListener.java (1 hunk)
  • bloc/src/test/java/com/iluwatar/bloc/BlocTest.java (1 hunk)
  • bloc/src/test/java/com/iluwatar/bloc/BlocUiTest.java (1 hunk)
  • bloc/src/test/java/com/iluwatar/bloc/MainTest.java (1 hunk)
  • fluent-interface/README.md (1 hunk)
  • health-check/src/test/java/HealthEndpointIntegrationTest.java (5 hunks)
  • marker-interface/pom.xml (1 hunk)
  • marker-interface/src/test/java/GuardTest.java (2 hunks)
  • marker-interface/src/test/java/ThiefTest.java (2 hunks)
  • microservices-idempotent-consumer/src/test/java/com/iluwatar/idempotentconsumer/AppTest.java (1 hunk)
  • microservices-idempotent-consumer/src/test/java/com/iluwatar/idempotentconsumer/RequestStateMachineTests.java (1 hunk)
  • retry/pom.xml (1 hunk)
  • retry/src/test/java/com/iluwatar/retry/FindCustomerTest.java (3 hunks)
  • retry/src/test/java/com/iluwatar/retry/RetryExponentialBackoffTest.java (4 hunks)
  • retry/src/test/java/com/iluwatar/retry/RetryTest.java (4 hunks)
  • virtual-proxy/src/test/java/com/iluwatar/virtual/proxy/RealVideoObjectTest.java (2 hunks)
  • virtual-proxy/src/test/java/com/iluwatar/virtual/proxy/VideoObjectProxyTest.java (2 hunks)
Actionable Comments (0)
Skipped Comments (0)

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Review Summary

Commits Considered (1)
Files Processed (1)
  • marker-interface/src/test/java/ThiefTest.java (2 hunks)
Actionable Comments (0)
Skipped Comments (1)
  • marker-interface/src/test/java/ThiefTest.java [34-37]

    readability: "Add comment explaining assertion."

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Review Summary

Commits Considered (1)
  • 5acd5e8: ETL design pattern issue-328
Files Processed (6)
  • etl/etc/etl.urm.puml (1 hunk)
  • etl/pom.xml (1 hunk)
  • etl/src/main/java/com/iluwatar/etl/App.java (1 hunk)
  • etl/src/main/java/com/iluwatar/etl/Extract.java (1 hunk)
  • etl/src/main/java/com/iluwatar/etl/Transform.java (1 hunk)
  • etl/src/main/resources/SocialMediaTop100.csv (1 hunk)
Actionable Comments (0)
Skipped Comments (0)

@varada610
Copy link
Author

varada610 commented Jan 31, 2025

Issue: Close JUnit and hamcrest
and #328

@varada610 varada610 changed the title Remove reference to hamcrest for testing Remove reference to hamcrest and added ETL pattern Jan 31, 2025
Copy link
Owner

@iluwatar iluwatar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Add the new module (ETL) to parent pom.xml. Otherwise it won't be built by CI.
  • ETL module is missing README.md. See contribution instructions to grasp the format that is required.
  • Actually, the other issue you are referencing (Update to JUnit 5 uml-reverse-mapper#91) belongs to uml-reverse-mapper project. But probably it is applicable here as well 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants