Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mismatched field type within shard causes panic [Port to main-2.x] #26001

Closed
davidby-influx opened this issue Feb 11, 2025 · 1 comment · Fixed by #26025
Closed

Mismatched field type within shard causes panic [Port to main-2.x] #26001

davidby-influx opened this issue Feb 11, 2025 · 1 comment · Fixed by #26025
Assignees
@davidby-influx
Labels
area/tsm area/2.x OSS 2.0 related issues and PRs kind/bug team/edge

Comments

@davidby-influx
Copy link
Contributor

Port #23756 to main-2.x branch
@davidby-influx davidby-influx self-assigned this Feb 11, 2025
@davidby-influx
Copy link
Contributor Author

Include ports of

#26022
#25998

davidby-influx added a commit that referenced this issue Feb 14, 2025
@davidby-influx
fix: lock MeasurementFields while validating (#25998)
295e990 
There was a window where a race between writes with
differing types for the same field were being validated.
Lock the  MeasurementFields struct during field
validation to avoid this.

closes #23756

(cherry picked from commit 5a20a83)

helps #26001
davidby-influx added a commit that referenced this issue Feb 14, 2025
@davidby-influx
fix: switch MeasurementFields from atomic.Value to sync.Map (#26022)
b7962ec 
Simplify and speed up synchronization for
MeasurementFields structures by switching
from a mutex and atomic.Value to a sync.Map

(cherry picked from commit b617eb2)

closes #26001
@davidby-influx davidby-influx mentioned this issue Feb 14, 2025
Merged
@davidby-influx davidby-influx linked a pull request Feb 14, 2025 that will close this issue
fix: prevent differing field types in the same shard #26025
Merged
davidby-influx added a commit that referenced this issue Feb 14, 2025
@davidby-influx
fix: prevent differing field types in the same shard (#26025)
8711e2d 
* fix: lock MeasurementFields while validating (#25998)

There was a window where a race between writes with
differing types for the same field were being validated.
Lock the  MeasurementFields struct during field
validation to avoid this.

closes #23756

(cherry picked from commit 5a20a83)

helps #26001

* fix: switch MeasurementFields from atomic.Value to sync.Map (#26022)

Simplify and speed up synchronization for
MeasurementFields structures by switching
from a mutex and atomic.Value to a sync.Map

(cherry picked from commit b617eb2)

closes #26001
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidby-influx davidby-influx

Labels
area/tsm area/2.x OSS 2.0 related issues and PRs kind/bug team/edge
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: prevent differing field types in the same shard influxdata/influxdb
1 participant
@davidby-influx