Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set default for datafusion memory pool #26009

Open
praveen-influx opened this issue Feb 13, 2025 · 0 comments · May be fixed by #26023
Open

Set default for datafusion memory pool #26009

praveen-influx opened this issue Feb 13, 2025 · 0 comments · May be fixed by #26023
Labels
v3

Comments

@praveen-influx
Copy link
Contributor

Problem statement

Current default for memory pool is set to 8G (here). This is probably fine for lower throughput, but with higher throughput and lower resources (like say container running with 4G max memory set), the influxdb3 process runs into OOM with no log message indicating what triggered the OOM.

Solution

It would be better to set a sane default - eg. 30% of available memory.

Alternatives considered

N/A

Additional context

This has been observed when snapshotting ran into OOMs (related issue), this comment that confirms that setting this to a lower value throws an allocation error.
praveen-influx added a commit that referenced this issue Feb 14, 2025
@praveen-influx
feat: updates to default memory settings
1828ddf 
- breaking change, replaced `--parquet-mem-cache-size-mb` and env var for
  it with `--parquet-mem-cache-size` (takes value now in bytes) and it
  now defauls to 20% of total available memory
- force snapshotting is set at 50%
- datafusion mem pool is set to 20%

closes: #26009
@praveen-influx praveen-influx linked a pull request Feb 14, 2025 that will close this issue
Draft
praveen-influx added a commit that referenced this issue Feb 14, 2025
@praveen-influx
feat: updates to default memory settings
06fe510 
- breaking change, replaced `--parquet-mem-cache-size-mb` and env var for
  it with `--parquet-mem-cache-size` (takes value now in percentage or
  MB), now defaults to 20% of total available memory
- force snapshotting is set at 50%
- datafusion mem pool is set to 20%

closes: #26009
praveen-influx added a commit that referenced this issue Feb 14, 2025
@praveen-influx
feat: updates to default memory settings
794cf3f 
- breaking change, replaced `--parquet-mem-cache-size-mb` and env var for
  it with `--parquet-mem-cache-size` (takes value now in percentage or
  MB), now defaults to 20% of total available memory
- force snapshotting is set at 50%
- datafusion mem pool is set to 20%

closes: #26009
praveen-influx added a commit that referenced this issue Feb 14, 2025
@praveen-influx
feat: updates to default memory settings
54f3637 
- breaking change, replaced `--parquet-mem-cache-size-mb` and env var for
  it with `--parquet-mem-cache-size` (takes value now in percentage or
  MB), now defaults to 20% of total available memory
- force snapshotting is set at 50%
- datafusion mem pool is set to 20%

closes: #26009
praveen-influx added a commit that referenced this issue Feb 14, 2025
@praveen-influx
feat: updates to default memory settings
c8b585e 
- breaking change, replaced `--parquet-mem-cache-size-mb` and env var for
  it with `--parquet-mem-cache-size` (takes value now in percentage or
  MB), now defaults to 20% of total available memory
- force snapshotting is set at 50%
- datafusion mem pool is set to 20%

closes: #26009
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
v3
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: updates to default memory settings influxdata/influxdb
1 participant
@praveen-influx