New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JavaScript best practices #7

Open

inspecta opened this issue Oct 3, 2022 · 0 comments

Assignees

Owner

inspecta commented Oct 3, 2022

Hello @inspecta, amazing work with this project 👏 👍
I have noticed the following JavaScript good practices;

No script tags
Type checks are okay
Node modules are in the .gitignore file
No console.logs, no alerts, no document.write or eval()
-No commented out code in the repo

A few bad practices noticed include;

DRY. Some pieces of code were repeated

https://github.com/inspecta/todo-list-webpack/blob/main/src/modules/addTask.js#L14-L31

inspecta self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment