Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add getter/setter for extractor_tasks of BaseSession #759

Open
bimac opened this issue Jan 21, 2025 · 0 comments
Open

add getter/setter for extractor_tasks of BaseSession #759

bimac opened this issue Jan 21, 2025 · 0 comments

Comments

@bimac
Copy link
Contributor

bimac commented Jan 21, 2025

Choosing the correct extractor tasks in a task init method causes problems as the superclass init already writes the extractor tasks to the experiment_description property which then must be modified by the subclass init:
https://github.com/int-brain-lab/project_extraction/blob/b68545e921c2a93e14eeae652921133d21bc73c4/iblrig_custom_tasks/samuel_cuedBiasedChoiceWorld/task.py#L25-L28

This problem is somewhat mitigated as tasks can be called XBpod, XTimeline, XNidq, etc. in which case calling the task X in the experiment description will cause the pipeline to choose the correct class based on the sync. For irregularly-named classes, however, the name should be defined explicitly so for this to be done dynamically we should have a getter and setter for the extractor_tasks property that can be overloaded by subclasses.

@k1o0 k1o0 removed their assignment Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants