Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker: remove docker_helper.docker_compose usage #357

Open
slint opened this issue Jul 18, 2023 · 0 comments
Open

docker: remove docker_helper.docker_compose usage #357

slint opened this issue Jul 18, 2023 · 0 comments

Comments

@slint
Copy link
Member

slint commented Jul 18, 2023

In the codebase we're using docker_helper.docker_compose to reference the docker compose command, instead of directly using ["docker", "compose"]. For simplicity we should review the usage of the Docker helper, and re-evaluate if we need this abstraction at this point, or just trust that the tool will remain somewhat stable.

Originally posted by @slint in #352 (comment)
@slint slint mentioned this issue Jul 18, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@slint