-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gonb CLI version #158
Comments
These look awesome.! You may as well change the |
I've made this PR #160. I'd appreciate your review 😄 . Here is the updated ![]() And here is the updated CLI version: ![]() |
v0.10.11 is released with the new I changed it to pick the version number not from the git current tag, but from a Thanks again @tonidy Btw, would you be interested in implementing #159 as well ? cheers |
Congratulations on new release 🥳 , I noticed when updating to gonb v0.10.11, the version control info was missing.
Usually I just added git tag and then build the binary, so go will use
No worries mate, I hope my contribution will benefit to the community.
I'll check into that issue when I've some free time. |
While debugging this issue (dotnet/interactive#3511), I noticed that
gonb -version
does not exist, even though we have%version
. Can we add a CLI version option?I’ve attempted to create a version parameter:
Long version
Short version
If this looks good, then I'll go ahead and create a PR.
The text was updated successfully, but these errors were encountered: