Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global items #3

Open
vitkarpov opened this issue Sep 8, 2013 · 1 comment
Open

Global items #3

vitkarpov opened this issue Sep 8, 2013 · 1 comment

Comments

@vitkarpov
Copy link

Is it really good idea to use global var items? We operate it in the cart collection`s add event.

We should customize Backbone.sync to handle it, shouldn`t we?

@jackfranklin
Copy link
Contributor

You're right - there's no need for items to be global. I would probably move it inline and just do:

new CartCollextion([
  {item1...},
  {item2...}
])

Or similar. Of course, if you have a server, it would make more sense to set up the collection to fetch from the server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants