Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Options to change the code template #12

Open
mrbinky3000 opened this issue Jan 10, 2017 · 6 comments
Open

Options to change the code template #12

mrbinky3000 opened this issue Jan 10, 2017 · 6 comments

Comments

@mrbinky3000
Copy link

Thanks for creating this. It's almost exactly what I was looking for.

How do you pass your own custom template to wrap the rendered tag and the html source?

@javiercf
Copy link
Owner

Can you give me an example of what you want to achieve?

@lukaswelinder
Copy link

@javiercf In many situations I find that the demo code needs to be more complicated than the codeblock. It would be nice to have some control over the way the block is handled.

@mrbinky3000
Copy link
Author

Simply allow us to set the template as a string of HTML. Your current template shows us the formatted code, and inserts the rendered Component. It would be nice if those two things could be replaced by placeholders in our template string. For example <div>{{code}}</div><div>{{component}}</div>

@mrbinky3000
Copy link
Author

I'm using handlebars above, but use any method you like.

@lukaswelinder
Copy link

lukaswelinder commented Jan 24, 2017

@mrbinky3000 I was thinking something more along the lines of convention on the language/render declaration:

// Render component only:
~~~ render
<Component { ...props } />
~~~
// Render with code block:
~~~ render jsx
<Component { ...props } />
~~~

However I do like the idea of being able to decide where the component is rendered:

~~~ render(componentName) jsx
<Component { ...props } />
~~~

... some README stuff
{ componentName.codeblock }
... more README stuff
{ componentName.component }

Or something along those lines...

@fernandopasik
Copy link
Collaborator

I think if we support a custom template for the code source and executed, we'll need to add an option in the loader that would go into the webpack config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants