Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let inline components render without code block #21

Open
jzaefferer opened this issue Jul 10, 2017 · 1 comment
Open

Let inline components render without code block #21

jzaefferer opened this issue Jul 10, 2017 · 1 comment

Comments

@jzaefferer
Copy link

I have a slightly different usecase for this package than the 'styleguide'. I'd like to define some Markdown content, and mix in other React components, but without rendering those components as html.

The change for that seems pretty trivial, though I'm not sure what unintended effects this might have: https://github.com/jzaefferer/react-markdown-loader/commit/24a57c1e372f7aeba16573cd8c926aa83f26e36c#diff-6947033678b93d106e25614dd972e66fR39

If the usecase is valid and that approach okay, I can create a pull request with that change, without the package.json changes (I needed that since yarn won't install from git).

@jamesmfriedman
Copy link

I made quite a few changes to support this for my RMWC library. https://jamesmfriedman.github.io/rmwc/

Basically I wanted code only, render only, and render with code. I also wanted to be able to use inline import statements for my examples.

https://github.com/jamesmfriedman/react-markdown-loader

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants