-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove jacoco
from the managed set
#4433
Comments
Jacoco plugin is an optional dependency on Pipeline Maven plugin (https://github.com/jenkinsci/pipeline-maven-plugin/blob/658737b64753e2834e5d79181531d9d5fe0276a8/pipeline-maven/pom.xml#L150). Is it essential to remove it? EDIT: nevermind, I'm not sure the code would work properly without the plugin: https://github.com/jenkinsci/pipeline-maven-plugin/blob/master/pipeline-maven/src/main/java/org/jenkinsci/plugins/pipeline/maven/publishers/JacocoReportPublisher.java |
Not sure offhand. If the BOM/PCT test suite passes with JaCoCo plugin removed, then I guess we would not need to touch Pipeline Maven plugin. |
It may pass now, but then cause problems later when dependencies in |
That does seem safest. |
I can work on that. |
https://plugins.jenkins.io/jacoco/ is formally deprecated, so no need to manage this anymore. But first we probably need to remove its integration in the non-deprecated Pipeline Maven plugin.
The text was updated successfully, but these errors were encountered: