Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jacoco from the managed set #4433

Open
basil opened this issue Feb 10, 2025 · 6 comments · May be fixed by #4641
Open

Remove jacoco from the managed set #4433

basil opened this issue Feb 10, 2025 · 6 comments · May be fixed by #4641

Comments

@basil
Copy link
Member

basil commented Feb 10, 2025

https://plugins.jenkins.io/jacoco/ is formally deprecated, so no need to manage this anymore. But first we probably need to remove its integration in the non-deprecated Pipeline Maven plugin.

@alecharp
Copy link
Member

alecharp commented Mar 3, 2025

Jacoco plugin is an optional dependency on Pipeline Maven plugin (https://github.com/jenkinsci/pipeline-maven-plugin/blob/658737b64753e2834e5d79181531d9d5fe0276a8/pipeline-maven/pom.xml#L150). Is it essential to remove it?

EDIT: nevermind, I'm not sure the code would work properly without the plugin: https://github.com/jenkinsci/pipeline-maven-plugin/blob/master/pipeline-maven/src/main/java/org/jenkinsci/plugins/pipeline/maven/publishers/JacocoReportPublisher.java

@basil
Copy link
Member Author

basil commented Mar 3, 2025

Not sure offhand. If the BOM/PCT test suite passes with JaCoCo plugin removed, then I guess we would not need to touch Pipeline Maven plugin.

@alecharp alecharp linked a pull request Mar 4, 2025 that will close this issue
6 tasks
@jglick
Copy link
Member

jglick commented Mar 4, 2025

It may pass now, but then cause problems later when dependencies in jacoco and dependencies in pipeline-maven fall out of synch. (One of the original purposes of creating bom was to prevent this sort of misalignment.) OTOH if jacoco is rarely touched and only pipeline-maven is getting POM updates maybe this will not become an issue. Regardless, the integration in pipeline-maven ought to be removed I guess. (It could perhaps be moved to jacoco to minimize disruption for anyone still relying on jacoco.)

@basil
Copy link
Member Author

basil commented Mar 4, 2025

Regardless, the integration in pipeline-maven ought to be removed I guess.

That does seem safest.

@alecharp
Copy link
Member

alecharp commented Mar 4, 2025

the integration in pipeline-maven ought to be removed I guess.

I can work on that.

@alecharp
Copy link
Member

alecharp commented Mar 5, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants