Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overwritePluginsFromImage works not as expected #1153

Open
bmaehr opened this issue Jul 12, 2024 · 4 comments
Open

overwritePluginsFromImage works not as expected #1153

bmaehr opened this issue Jul 12, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@bmaehr
Copy link

bmaehr commented Jul 12, 2024

Describe the bug

When setting overwritePluginsFromImage=false I would expect that the plugins from image stay in their version but plugins from installPlugins or additionalPlugins are added. But that fails, because the "/usr/share/jenkins/ref/plugins" is Read-only file system.

In fact I just try to get a setup where a list of base plugins are downloaded while the docker build phase and then some additional plugins could be added through the chart. But I was not able to get this - IMHO not very special - use case to work

Version of Helm and Kubernetes

- Helm: 3.10.2
- Kubernetes: v1.29.6-gke.1254000

Chart version

4.12.1

What happened?

1. Add plugins to custom image by jenkins-plugin-cli
2. Use custom image in chart
3. Add additional plugins to installPlugins
4. Container is not starting up

What you expected to happen?

Have the plugins form the base image and from installPlugins or additionalPlugins

How to reproduce it

No response

Anything else we need to know?

No response

@bmaehr bmaehr added the bug Something isn't working label Jul 12, 2024
@jesrig
Copy link
Contributor

jesrig commented Jul 30, 2024

@bmaehr Would you mind updating the exact steps to reproduce on the How to Reproduce It section? I want to be totally clear about this issue

@bmaehr
Copy link
Author

bmaehr commented Jul 30, 2024

I would ask the other way round: Have you tried to add plugins to the image and add further plugins by the chart? If it is possible in some way, that would be an option for me.

What I have done:
In the Dockerfile added

RUN jenkins-plugin-cli --plugins \
    ant:latest \
    antisamy-markup-formatter:latest \
    ansicolor:latest \
    ...

and added

additionalPlugins:
    - kubernetes:1.27.6
    - workflow-aggregator:2.6
    - git:4.4.5
    - configuration-as-code:1.46
    - Docker:1.2.1

to the values of the chart.

@jesrig
Copy link
Contributor

jesrig commented Aug 1, 2024

@bmaehr I can't recreate your issue. Here are the steps I took:

  1. Created an Dockerfile and pushed the resulting image up to my repository
FROM jenkins/jenkins:lts

RUN jenkins-plugin-cli --plugins \
    ant:latest \
    antisamy-markup-formatter:latest \
    ansicolor:latest \
  1. Set this image as the contoller image
  2. Left default installPlugins intact
  3. Updated additionalPlugins
  additionalPlugins:
    - ansible:307.va_1f3ef06575a_
  1. Ran tilt up in the chart repo.

Result:
I see all the plugins in the /var/jenkins_home/plugins folder as expected.

@jesrig
Copy link
Contributor

jesrig commented Aug 7, 2024

@bmaehr If this issue is resolved, can you close it?

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants