Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slack endpoint needs fallback text #26

Open
jloh opened this issue Mar 30, 2018 · 0 comments
Open

Slack endpoint needs fallback text #26

jloh opened this issue Mar 30, 2018 · 0 comments
Labels

Comments

@jloh
Copy link
Owner

jloh commented Mar 30, 2018

The slack endpoint currently doesn't have any fallback text. This is very poor form and goes against their standards!

geojs/conf/v1/hooks.conf

Lines 255 to 268 in c7e8c5b

message = {
response_type = slack_response_type,
attachments = {{
mrkdwn_in = {
"text",
"pretext"
},
fallback = "", -- TODO: Actually put something here good lord
pretext = title,
text = resp,
footer = "Powered by <https://geojs.io|GeoJS>",
footer_icon = "https://static.jloh.co/geojs/avatar/hipchat/v1/geojs-icon_2x.png"
}}
}

@jloh jloh added hooks/slack API v1 API Version 1 labels Mar 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant