Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show loading wheel for initial SAY_READY action instead of READY button #131

Open
joffrey-bion opened this issue Feb 23, 2021 · 0 comments
Labels
cosmetic Visual improvements to make things look nicer

Comments

@joffrey-bion
Copy link
Owner

joffrey-bion commented Feb 23, 2021

At the very beginning of the game, the action type is SAY_READY because the server waits for all clients to say that they have setup all subscriptions.

This makes the UI display the old "READY" button for a very brief instant.

We could instead display a loading wheel with a message like "Loading..." (before sayReady call) or "Waiting for other players to join..." (after our own sayReadycall), the same way we handle the WAIT action:
#72

@joffrey-bion joffrey-bion added the cosmetic Visual improvements to make things look nicer label Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cosmetic Visual improvements to make things look nicer
Projects
None yet
Development

No branches or pull requests

1 participant