Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

max length of player name #167

Open
bgstack15 opened this issue Jul 11, 2023 · 4 comments
Open

max length of player name #167

bgstack15 opened this issue Jul 11, 2023 · 4 comments
Labels
cosmetic Visual improvements to make things look nicer

Comments

@bgstack15
Copy link
Contributor

While an absurdly long player name is truncated during gameplay, it is not truncated on the summary page. Would you please consider truncating this after so many characters (30 or 40 or something?)

@joffrey-bion
Copy link
Owner

Hi, thanks for the report. A screenshot would help quite a bit in this kind of case.

What do you mean by the summary page? Do you mean the lobby before the game, with the table? Or the game browser with the list of games and the username in the top right?

@bgstack15
Copy link
Contributor Author

At the end of the game, when you are viewing the points, the long name makes the table very wide and basically unreadable. You can zoom out and then view information.

@joffrey-bion
Copy link
Owner

Ah, got it, thanks

@joffrey-bion
Copy link
Owner

Maybe we should just prevent player names that are unrealistically long. I don't think there is a point in a player name of more than 30-40 characters. And it would avoid problems in places where it's nice to see the full non-ellipsized name (like the game browser).

But I agree that maybe in the score table we don't want any name to span multiple lines, and should probably prefer to ellipsize it in this case.

@joffrey-bion joffrey-bion added the cosmetic Visual improvements to make things look nicer label Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cosmetic Visual improvements to make things look nicer
Projects
None yet
Development

No branches or pull requests

2 participants