Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add secondary Color when selecting manually a new color #530

Open
thoroc opened this issue Aug 11, 2023 · 2 comments
Open

Add secondary Color when selecting manually a new color #530

thoroc opened this issue Aug 11, 2023 · 2 comments

Comments

@thoroc
Copy link

thoroc commented Aug 11, 2023

Currently it is possible to specify a single color code for the primary color. However it would be quite nice to be able to specify a secondary color.

I would think something like the color shown in https://brandpalettes.com/javascript-logo-colors/

@johnpapa
Copy link
Owner

Thank you @thoroc for creating this issue!

@thoroc
Copy link
Author

thoroc commented Aug 11, 2023

I have just realised there is only the primary color being saved in the user settings files (~/Library/Application\ Support/Code/User/settings.json on MacOS). It be great if a secondary color could be introduced.

There reasoning is that I wanted to use the colors from https://brandpalettes.com/amazon-web-services-logo-colors/, but upon saving the first one as a new Favourite, I end up with something quite different.

This is the color palette from the favorite

{
  "workbench.colorCustomizations": {
    "activityBar.activeBackground": "#ffad33",
    "activityBar.background": "#ffad33",
    "activityBar.foreground": "#15202b",
    "activityBar.inactiveForeground": "#15202b99",
    "activityBarBadge.background": "#00804c",
    "activityBarBadge.foreground": "#e7e7e7",
    "commandCenter.border": "#15202b99",
    "sash.hoverBorder": "#ffad33",
    "statusBar.background": "#ff9900",
    "statusBar.foreground": "#15202b",
    "statusBarItem.hoverBackground": "#cc7a00",
    "statusBarItem.remoteBackground": "#ff9900",
    "statusBarItem.remoteForeground": "#15202b",
    "titleBar.activeBackground": "#ff9900",
    "titleBar.activeForeground": "#15202b",
    "titleBar.inactiveBackground": "#ff990099",
    "titleBar.inactiveForeground": "#15202b99"
  },
  "peacock.color": "#ff9900",
}

This is the color palette I would have rather had:

{
  "workbench.colorCustomizations": {
    "activityBar.activeBackground": "#ffad33",
    "activityBar.background": "#ffad33",
    "activityBar.foreground": "#252F3E",
    "activityBar.inactiveForeground": "#252F3E99",
    "activityBarBadge.background": "#146EB4",
    "activityBarBadge.foreground": "#e7e7e7",
    "commandCenter.border": "#252F3E99",
    "sash.hoverBorder": "#ffad33",
    "statusBar.background": "#ff9900",
    "statusBar.foreground": "#252F3E",
    "statusBarItem.hoverBackground": "#cc7a00",
    "statusBarItem.remoteBackground": "#ff9900",
    "statusBarItem.remoteForeground": "#252F3E",
    "titleBar.activeBackground": "#ff9900",
    "titleBar.activeForeground": "#252F3E",
    "titleBar.inactiveBackground": "#ff990099",
    "titleBar.inactiveForeground": "#252F3E99"
  },
  "peacock.color": "#ff9900"
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants