Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some comments #2

Open
hherlyng opened this issue Nov 6, 2023 · 3 comments
Open

Some comments #2

hherlyng opened this issue Nov 6, 2023 · 3 comments

Comments

@hherlyng
Copy link

hherlyng commented Nov 6, 2023

  1. Add function expressions for the Lagrange element basis functions shown in "An introduction to the unified form language"? Would make it clearer that the planes in the figure "First order Lagrange basis functions" are spanned by the basis functions
  2. When printing the basix tabulations, specify what the array values printed are? (if I understood correctly they are the function values of the basis functions in the tabulated points?)
  3. In the introduction under "The computational domain" it says "For now, we don’t know if we are solving the Poisson equation on..." but the impression from the start is that we are to solve a projection problem?
  4. The "Code generation" chapter begins with "All the code in the previous section is Python code symbolically describing the variational form of the projection. This is why we in FEniCS rely on code generation." It's not entirely clear why we need code generation, is it because the code is symbolic and we need to convert the code to something we can evaluate?
  5. Transition from "Code generation" chapter to "Mesh generation" is somewhat abrupt, but you might be planning to add something? Would suffice to e.g. just add a comment to what is being printed when you're inspecting the introduction.c code.
@jorgensd
Copy link
Owner

jorgensd commented Nov 6, 2023

  1. Add function expressions for the Lagrange element basis functions shown in "An introduction to the unified form language"? Would make it clearer that the planes in the figure "First order Lagrange basis functions" are spanned by the basis functions

Will fix

  1. When printing the basix tabulations, specify what the array values printed are? (if I understood correctly they are the function values of the basis functions in the tabulated points?)

Will add a slightly more verbose print

  1. In the introduction under "The computational domain" it says "For now, we don’t know if we are solving the Poisson equation on..." but the impression from the start is that we are to solve a projection problem?

Remainder from when I was thinking about using Poisson as an example, will fix.

@jorgensd
Copy link
Owner

jorgensd commented Nov 6, 2023

  1. The "Code generation" chapter begins with "All the code in the previous section is Python code symbolically
    describing the variational form of the projection. This is why we in FEniCS rely on code generation." It's not entirely
    clear why we need code generation, is it because the code is symbolic and we need to convert the code to something > we can evaluate?

Will make a better justification/explaination

  1. Transition from "Code generation" chapter to "Mesh generation" is somewhat abrupt, but you might be planning
    to add something? Would suffice to e.g. just add a comment to what is being printed when you're inspecting the
    introduction.c code.

Will think of a way of bridging the gap

@jorgensd
Copy link
Owner

jorgensd commented Oct 3, 2024

@hherlyng do you mind revisiting these points?

  1. Major refactoring of the tutorial has happened, introduction is way more basi(x)c now: http://jsdokken.com/FEniCS23-tutorial/src/introduction.html

  2. Should be dealt with in the refactoring

  3. Fixed

  4. Tried to add some comments on why we need this.

  5. This year the lecture is split in 2, this is where the second lecture will start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants