-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Svelte 5 support #452
Comments
The editor isn't yet ready for Svelte 5. I did a short test recently trying to upgrade to Svelte 5. That gives some styling issues, the modals do not work (with a clear error), and a list of compiler warnings. It doesn't look that complicated to fix, but it will take time and requires extensive testing. Also, some of the dependencies, like On a side note: Svelte 5 is not yet production ready, so it is good to prepare for it but we still need some patience :) |
See #476 There are quite some issues that need to get resolved. Any help would be welcome. |
Just FYI: I guess this now is implemented? https://github.com/josdejong/svelte-jsoneditor/releases/tag/v2.0.0 |
Ah, yes, I didn't realize there was a separate issue about Svelte 5 support, this can be closed now. Implemented via #490. |
I'm working on a project that uses svelte-jsoneditor. All is well when using the 4.x version of Svelte, but I tried using Svelte 5 today and there seems to be a problem with the svelte preprocessor:
I'm not sure why the problem which seems to be triggered by the pre-processor only shows up with 5.
I created a simple project that shows the issue here: https://github.com/chillenious/svelte-jsoneditor-issue. Note that simply by changing the svelte to a 4.x dependency, the project will work again.
The text was updated successfully, but these errors were encountered: