Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unicode URL support. #48

Open
buildAI opened this issue Oct 15, 2019 · 2 comments
Open

Unicode URL support. #48

buildAI opened this issue Oct 15, 2019 · 2 comments

Comments

@buildAI
Copy link

buildAI commented Oct 15, 2019 •
edited
Loading

Right now akismet as a a service supports unicode urls but this gem doesn't support unicode URLs. This is happening because ruby's URI parse supports only ASCII characters

example: blog_url: "https://www.example.com/हिंदीकामकररहेहैंयानहीं"
@buildAI
Copy link
Author

buildAI commented Oct 15, 2019

@joshfrench I am planning to pick up and work on this. Firstly do you agree with addition of this support? If you say yes. I would like to pick it up.

@joshfrench
Copy link
Owner

Pull requests welcome! Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joshfrench @buildAI