-
Notifications
You must be signed in to change notification settings - Fork 1
/
Copy path1016037-remove-actorids-wae.patch
113 lines (96 loc) · 4.36 KB
/
1016037-remove-actorids-wae.patch
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
From dc713cdd5150618acf58000962d2865ce3581840 Mon Sep 17 00:00:00 2001
From: Jordan Santell <[email protected]>
Date: Wed, 13 Aug 2014 15:10:30 -0700
Subject: bug 1016037 - Remove actor IDs from web audio editor's inspector r=vp
---
browser/devtools/webaudioeditor/test/browser_wa_inspector-toggle.js | 2 +-
browser/devtools/webaudioeditor/test/browser_wa_inspector.js | 4 ++--
browser/devtools/webaudioeditor/webaudioeditor-view.js | 2 +-
browser/themes/shared/devtools/webaudioeditor.inc.css | 4 ++++
4 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/browser/devtools/webaudioeditor/test/browser_wa_inspector-toggle.js b/browser/devtools/webaudioeditor/test/browser_wa_inspector-toggle.js
index 8fe636b..64f49b0 100644
--- a/browser/devtools/webaudioeditor/test/browser_wa_inspector-toggle.js
+++ b/browser/devtools/webaudioeditor/test/browser_wa_inspector-toggle.js
@@ -53,14 +53,14 @@ function spawnTest() {
click(panelWin, findGraphNode(panelWin, nodeIds[1]));
yield once(panelWin, EVENTS.UI_INSPECTOR_NODE_SET);
ok(!isVisible($("#web-audio-editor-details-pane-empty")),
"Empty message hides even when loading node while open.");
ok(isVisible($("#web-audio-editor-tabs")),
"Switches to tab view when loading node while open.");
- is($("#web-audio-inspector-title").value, "OscillatorNode (" + nodeIds[1] + ")",
+ is($("#web-audio-inspector-title").value, "Oscillator",
"Inspector title updates when loading node while open.");
yield teardown(panel);
finish();
}
diff --git a/browser/devtools/webaudioeditor/test/browser_wa_inspector.js b/browser/devtools/webaudioeditor/test/browser_wa_inspector.js
index b8e2147..1db3f44 100644
--- a/browser/devtools/webaudioeditor/test/browser_wa_inspector.js
+++ b/browser/devtools/webaudioeditor/test/browser_wa_inspector.js
@@ -38,23 +38,23 @@ function spawnTest() {
]);
ok(WebAudioInspectorView.isVisible(), "InspectorView shown once node selected.");
ok(!isVisible($("#web-audio-editor-details-pane-empty")),
"InspectorView empty message hidden when node selected.");
ok(isVisible($("#web-audio-editor-tabs")),
"InspectorView tabs view visible when node selected.");
- is($("#web-audio-inspector-title").value, "OscillatorNode (" + nodeIds[1] + ")",
+ is($("#web-audio-inspector-title").value, "Oscillator",
"Inspector should have the node title when a node is selected.");
is($("#web-audio-editor-tabs").selectedIndex, 0,
"default tab selected should be the parameters tab.");
click(panelWin, findGraphNode(panelWin, nodeIds[2]));
yield once(panelWin, EVENTS.UI_INSPECTOR_NODE_SET);
- is($("#web-audio-inspector-title").value, "GainNode (" + nodeIds[2] + ")",
+ is($("#web-audio-inspector-title").value, "Gain",
"Inspector title updates when a new node is selected.");
yield teardown(panel);
finish();
}
diff --git a/browser/devtools/webaudioeditor/webaudioeditor-view.js b/browser/devtools/webaudioeditor/webaudioeditor-view.js
index 124defe..4fbe8d8 100644
--- a/browser/devtools/webaudioeditor/webaudioeditor-view.js
+++ b/browser/devtools/webaudioeditor/webaudioeditor-view.js
@@ -447,17 +447,17 @@ let WebAudioInspectorView = {
this.toggleInspector({ visible: false, animated: false, delayed: false });
},
/**
* Sets the title of the Inspector view
*/
_setTitle: function () {
let node = this._currentNode;
- let title = node.type + " (" + node.id + ")";
+ let title = node.type.replace(/Node$/, "");
$("#web-audio-inspector-title").setAttribute("value", title);
},
/**
* Reconstructs the `Properties` tab in the inspector
* with the `this._currentNode` as it's source.
*/
_buildPropertiesView: Task.async(function* () {
diff --git a/browser/themes/shared/devtools/webaudioeditor.inc.css b/browser/themes/shared/devtools/webaudioeditor.inc.css
index 887bfdc..4d2665e 100644
--- a/browser/themes/shared/devtools/webaudioeditor.inc.css
+++ b/browser/themes/shared/devtools/webaudioeditor.inc.css
@@ -94,16 +94,20 @@ text {
.theme-light g.selected text {
fill: #f0f1f2; /* Toolbars */
}
/**
* Inspector Styles
*/
+#web-audio-inspector-title {
+ margin: 6px;
+}
+
.web-audio-inspector .error {
background-image: url(alerticon-warning.png);
background-size: 13px 12px;
-moz-appearance: none;
opacity: 0;
transition: opacity .5s ease-out 0s;
}
--
1.8.4.2