Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to support React 16 #33

Open
gimdongwoo opened this issue Nov 12, 2017 · 1 comment
Open

Need to support React 16 #33

gimdongwoo opened this issue Nov 12, 2017 · 1 comment

Comments

@gimdongwoo
Copy link
Collaborator

React 16 has a lot of changes compared to 15, so we need to deal with it.

@bgribble
Copy link

I'm using react-chatview 0.2.5 vs. react 16.2.0 with basically no problems but one bad behavior that I can't pin down. When I switch from a large set of items to display down to a smaller set without unmounting the <ReactChatview />, under some circumstances there are leftover children from the previous dataset still in the DOM, but which do not appear in the component's props.children. Unmounting and remounting fixes this problem.

As usual this is probably my own damn fault somehow but I believe I've only seen it since we migrated to React 16 a couple of weeks ago. I'll try to get more information to make this a useful report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants