From 6880f01915e569ba1b6380b6ae8408a0bfbf681f Mon Sep 17 00:00:00 2001 From: Simon Li Date: Sun, 26 Jan 2025 13:54:02 +0000 Subject: [PATCH 1/2] If ServerApp.ip is ipv6 use [::1] as local_url --- jupyter_server/serverapp.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/jupyter_server/serverapp.py b/jupyter_server/serverapp.py index 8aa3dbd08..f38688f4f 100644 --- a/jupyter_server/serverapp.py +++ b/jupyter_server/serverapp.py @@ -2377,7 +2377,11 @@ def local_url(self) -> str: parts = self._get_urlparts(include_token=True) # Update with custom pieces. if not self.sock: - parts = parts._replace(netloc=f"127.0.0.1:{self.port}") + if ":" in self.ip: + localhost = "[::1]" + else: + localhost = "127.0.0.1" + parts = parts._replace(netloc=f"{localhost}:{self.port}") return parts.geturl() @property From 204ce75262b9e3ca65f7c2917f863dc636bd86b2 Mon Sep 17 00:00:00 2001 From: Simon Li Date: Sun, 26 Jan 2025 15:02:41 +0000 Subject: [PATCH 2/2] Use ternary for ipv4/ipv6 output --- jupyter_server/serverapp.py | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/jupyter_server/serverapp.py b/jupyter_server/serverapp.py index f38688f4f..e65665f59 100644 --- a/jupyter_server/serverapp.py +++ b/jupyter_server/serverapp.py @@ -2377,10 +2377,7 @@ def local_url(self) -> str: parts = self._get_urlparts(include_token=True) # Update with custom pieces. if not self.sock: - if ":" in self.ip: - localhost = "[::1]" - else: - localhost = "127.0.0.1" + localhost = "[::1]" if ":" in self.ip else "127.0.0.1" parts = parts._replace(netloc=f"{localhost}:{self.port}") return parts.geturl()