Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.33%. Comparing base (9d0e56c) to head (2f47d5e).
Report is 4 commits behind head on master.

@@           Coverage Diff           @@
##           master     #253   +/-   ##
=======================================
  Coverage   95.33%   95.33%           
=======================================
  Files          14       14           
  Lines        1630     1630           
=======================================
  Hits         1554     1554           
  Misses         76       76           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

I don't like this proposed change, also for example the unify integration shows some entities under the altherma device as it also uses the mac address

I did a very broad review of the official HA components and I couldn't find any cloud integration that exposed MAC addresses in the DeviceInfo class.

I understand that no longer merging the entities provided by the unify integration could be annoying to some, but the entities will still be available, it won't affect dashboards.

On the other hand, people using both the official daikin integration and this one are stuck with duplicate entities they can't easily get rid of. This PR started after your suggestion in #240 (comment), which would work if this PR is merged.

What's your final stance on this? Do you see a better solution? I've been running this patch for ~1 week now and it fixes the issue of duplicates for me. I don't mind using my own fork for the foreseeable future , but would rather get the changes upstream if possible.

Just back after a week of vacation, need to look more into this and test a few things. The concept that a single device is exposed by multiple components seems to match the HA concepts (see https://developers.home-assistant.io/docs/device_registry_index/).

I totally agree with the fact that a device's entities might be exposed by different components, the example you gave with the UniFi integration is a good one, they complement each other. But the daikin / dainkin_onecta interaction is pretty weird right now since they duplicate almost all the entities, so it makes it look like each AC unit has two thermostats.

Maybe I went about it the wrong way. At first I tried to add a "skip devices" entry in the config flow. I could select the devices created by the daikin integration. I got their device IDs, but I'm not sure how to match those with what the Onecta API returns. Do you think this is worth pursuing further?

I need a little bit more time to think about this. In my setup I don't have AC units with local control, but I do have a somfy tahoma box, that exposes some of the sensors of the Daikin AC units also, but only the temperature ones readonly, no control. I don't have added those to my dashboard.

I still don't like this approach, I see several core integrations adding the mac address, I think in your use case you just have to disable the entities you don't want once, or just don't use them on your dashboards.